[PATCH 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator().

[Paul Gofman (＠gofman)]

Fixes a regression introduced by
2efb00bc850f69ebd994d715bdd510d7ced41b12.

Sorry for that.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

[PATCH 1/1] mmdevapi: Unlock session in create_session_enumerator().

[Paul Gofman]

From: Paul Gofman <pgofman(a)codeweavers.com>

Fixes a regression introduced by
2efb00bc850f69ebd994d715bdd510d7ced41b12.
---
 dlls/mmdevapi/audiosessionmanager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mmdevapi/audiosessionmanager.c b/dlls/mmdevapi/audiosessionmanager.c
index 5c8d1e80cd0..ddc45423700 100644
--- a/dlls/mmdevapi/audiosessionmanager.c
+++ b/dlls/mmdevapi/audiosessionmanager.c
@@ -161,7 +161,7 @@ static HRESULT create_session_enumerator(IMMDevice *device, IAudioSessionEnumera
 
     sessions_lock();
     hr = get_audio_sessions(device, &enumerator->sessions, &enumerator->session_count);
-    sessions_lock();
+    sessions_unlock();
     if (FAILED(hr))
     {
         free(enumerator);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

[PATCH 1/1] mmdevapi: Unlock session in create_session_enumerator().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147598

Your paranoid android.


=== debian11b (64 bit WoW report) ===

dinput:
hid.c:722: Test failed: IOCTL_WINETEST_REMOVE_DEVICE failed, last error 6

hid:
device.c:123: Test failed: Failed to open L"\\\\?\\hid#vid_1209&pid_0001#0&0000&0#{4d1e55b2-f16f-11cf-88cb-001111000030}", error 3.
device.c:123: Test failed: Failed to open L"\\\\?\\hid#vid_1209&pid_0001&col01#256&wine test&0&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}", error 3.
device.c:123: Test failed: Failed to open L"\\\\?\\hid#vid_1209&pid_0001&col02#256&wine test&0&0&0001#{4d1e55b2-f16f-11cf-88cb-001111000030}", error 3.
device.c:123: Test failed: Failed to open L"\\\\?\\hid#vid_845e&pid_0001#0&0000&0&0&0#{4d1e55b2-f16f-11cf-88cb-001111000030}", error 3.
device.c:123: Test failed: Failed to open L"\\\\?\\hid#vid_845e&pid_0002#0&0000&0&0&0#{4d1e55b2-f16f-11cf-88cb-001111000030}", error 3.
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:319: Test failed: Failed to get product string(0x6)
device.c:323: Test failed: Failed to get preparsed data(0x6)
device.c:325: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:170: Test failed: got error 3
device.c:173: Test failed: Failed to get preparsed data(0x6)
device.c:175: Test failed: Failed to get Caps(0xc0110001)
device.c:405: Test failed: Failed to get product string(0x6)
device.c:409: Test failed: Failed to get preparsed data(0x6)
device.c:411: Test failed: Failed to get Caps(0xc0110001)

kernel32:
comm.c:1586: Test failed: Unexpected time 1000, expected around 500

user32:
input.c:2206: Test failed: got 0 messages
input.c:2216: Test failed: got 0 messages
input.c:1933: Test failed: expected non-zero
input.c:1939: Test failed: expected -1, got 0
input.c:1940: Test failed: expected 122, got -559038737
input.c:1941: Test failed: expected non-zero
input.c:1945: Test failed: expected non-zero
input.c:2080: Test failed: expected non-zero

[PATCH 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator(). - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6224