[PATCH 0/1] MR1094: winedump: Handle NULL in get_unicode_str.

[Piotr Caban (＠piotr)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1094

[PATCH 1/1] winedump: Handle NULL in get_unicode_str.

[Piotr Caban]

From: Piotr Caban <piotr(a)codeweavers.com>

---
 tools/winedump/dump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/winedump/dump.c b/tools/winedump/dump.c
index f2cb601b295..7d4a1a320d5 100644
--- a/tools/winedump/dump.c
+++ b/tools/winedump/dump.c
@@ -202,6 +202,7 @@ const char *get_unicode_str( const WCHAR *str, int len )
     char *buffer;
     int i = 0;
 
+    if (!str) return "(null)";
     if (len == -1) len = strlenW( str );
     buffer = dump_want_n( len * 6 + 3);
     buffer[i++] = '"';
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1094

[PATCH 1/1] winedump: Handle NULL in get_unicode_str.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125102

Your paranoid android.


=== debian11 (build log) ===

0568:err:winediag:d3d_device_create The application wants to create a Direct3D device, but the current DirectDrawRenderer does not support this.
0568:err:winediag:d3d_device_create The application wants to create a Direct3D device, but the current DirectDrawRenderer does not support this.
0568:err:winediag:d3d_device_create The application wants to create a Direct3D device, but the current DirectDrawRenderer does not support this.

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24747.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24747.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24747.