[PATCH 0/1] MR2757: ddraw: Set the texture height in SetSurfaceDesc() (Coverity).
This looked like a copy-paste error to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2757
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/ddraw/surface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 52ca900441c..d28ed240a05 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -4845,7 +4845,7 @@ static HRESULT WINAPI ddraw_surface7_SetSurfaceDesc(IDirectDrawSurface7 *iface, wined3d_resource_get_desc(wined3d_texture_get_resource(old_texture), &wined3d_desc); wined3d_desc.width = width; - wined3d_desc.width = height; + wined3d_desc.height = height; wined3d_desc.format = format_id; if (FAILED(hr = wined3d_texture_create(ddraw->wined3d_device, &wined3d_desc, 1, 1, @@ -4870,7 +4870,7 @@ static HRESULT WINAPI ddraw_surface7_SetSurfaceDesc(IDirectDrawSurface7 *iface, wined3d_resource_get_desc(wined3d_texture_get_resource(old_draw_texture), &wined3d_desc); wined3d_desc.width = width; - wined3d_desc.width = height; + wined3d_desc.height = height; wined3d_desc.format = format_id; if (FAILED(hr = wined3d_texture_create(ddraw->wined3d_device, &wined3d_desc, 1, 1, -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2757
This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2757
participants (3)
-
Sven Baars -
Sven Baars (@sbaars) -
Zebediah Figura (@zfigura)