Re: [PATCH v2 0/1] MR10090: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
On Fri Feb 13 03:36:38 2026 +0000, Fabian Maurer wrote:
Thanks for the PR, that would be a nice addition to Wine. Since you added me as reviewer: Sure, I can do my best to help review, but keep in mind that I'm also just a hobby contributor. I think some extensive tests on how exactly this behavior works would be nice. There seems to be quite a few weird behaviors that could be validated by tests. Fabian,
You are welcome for the PR. After viewing the failure log, I deduced that the issue resides with my modification of the resource loader function in the "loader.c" file. It has made me rethink how I trigger looking for a multi-language resource file, and I think I have come up with an even simpler solution. I will be trying my new idea out over the next few days, and hope to give a retry on the forking and merging next week. Regards, Craig -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10090#note_129573
participants (1)
-
Craig Schulstad (@NoDakker)