Re: [PATCH v3 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
4 Aug
2023
4 Aug
'23
5:59 p.m.
Not sure why I wasn't added as reviewer, but this looks wrong, and I think this doesn't fully solve the problem, either. As far as I can tell, if there's something else [what?] that pushes to the queue executing concurrently with Shutdown(), it'll end up pushing to an invalid queue handle after Shutdown() returns. This was already the case, but now it's worse, because you can't just fix it by setting source->async_commands_queue to NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491#note_41413
866
Age (days ago)
866
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zebediah Figura (@zfigura)