Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c:
> +    } static const video_types[] = {
> +        { &MEDIASUBTYPE_YV12, WG_VIDEO_FORMAT_YV12, 12, MAKEFOURCC('Y','V','1','2') },
> +        { &MEDIASUBTYPE_YUY2, WG_VIDEO_FORMAT_YUY2, 16, MAKEFOURCC('Y','U','Y','2') },
> +        { &MEDIASUBTYPE_UYVY, WG_VIDEO_FORMAT_UYVY, 16, MAKEFOURCC('U','Y','V','Y') },
> +        { &MEDIASUBTYPE_RGB24, WG_VIDEO_FORMAT_BGR, 24, BI_RGB },
> +        { &MEDIASUBTYPE_RGB32, WG_VIDEO_FORMAT_BGRx, 32, BI_RGB },
> +        { &MEDIASUBTYPE_RGB565, WG_VIDEO_FORMAT_RGB16, 16, BI_BITFIELDS },
> +        { &MEDIASUBTYPE_RGB555, WG_VIDEO_FORMAT_RGB15, 16, BI_RGB },
> +    };
> +
> +    MPEG1VIDEOINFO *input_format;
> +    VIDEOINFO *output_format;
> +
> +    if (!filter->sink.pin.peer)
> +        return VFW_S_NO_MORE_ITEMS;
> +
> That shouldn't be necessary. If the sink is disconnected the source won't even be exposed.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48903