[PATCH 0/1] MR3588: windows.media.devices: Define GUID_STR_LEN without using a magic number.

[Alex Henrie (＠alexhenrie)]

The exact number (38) is not very important, and using `ARRAY_SIZE` instead tells the reader that there is little chance that the number was calculated incorrectly.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3588

[PATCH 1/1] windows.media.devices: Define GUID_STR_LEN without using a magic number.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/windows.media.devices/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/windows.media.devices/main.c b/dlls/windows.media.devices/main.c
index a52f696f1ad..d3afbb58c97 100644
--- a/dlls/windows.media.devices/main.c
+++ b/dlls/windows.media.devices/main.c
@@ -164,7 +164,7 @@ static HRESULT get_default_device_id(EDataFlow direction, AudioDeviceRole role,
 
     static const WCHAR id_fmt_pre[] = L"\\\\?\\SWD#MMDEVAPI#";
     static const WCHAR id_fmt_hash[] = L"#";
-    static const size_t GUID_STR_LEN = 38; /* == strlen("{00000000-0000-0000-0000-000000000000}") */
+    static const size_t GUID_STR_LEN = ARRAY_SIZE(L"{12345678-1234-1234-1234-123456789abc}") - 1;
 
     *device_id_hstr = NULL;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3588

[PATCH 1/1] windows.media.devices: Define GUID_STR_LEN without using a magic number.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=136327

Your paranoid android.


=== debian11b (64 bit WoW report) ===

ntdll:
exception.c:3256: Test failed: B0 flag is not set in Dr6
exception.c:3257: Test failed: BS flag is set in Dr6