Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
16 Oct
2023
16 Oct
'23
11:46 p.m.
Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegsplit.c:
HRESULT hr;
hr = IMediaSample_GetTime(sample, &start, &end); - todo_wine_if (hr == VFW_S_NO_STOP_TIME) ok(hr == S_OK, "Got hr %#lx.\n", hr); + todo_wine_if (hr == VFW_S_NO_STOP_TIME) { + ok(hr == S_OK || (filter->sample_count > 0 && hr == VFW_E_SAMPLE_TIME_NOT_SET), "Got hr %#lx.\n", hr); + }
If Windows never sets the sample time for video samples after the first then we should probably make this check more restrictive to explicitly check that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48910
873
Age (days ago)
873
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zebediah Figura (@zfigura)