[PATCH 0/1] MR4664: wineps: Don't leak memory in error case (Coverity)

[Fabian Maurer (＠DarkShadow44)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

[PATCH 1/1] wineps: Don't leak memory in error case (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/wineps.drv/ps.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c
index 03c92aa00f0..d976f00433d 100644
--- a/dlls/wineps.drv/ps.c
+++ b/dlls/wineps.drv/ps.c
@@ -1028,6 +1028,7 @@ BOOL PSDRV_WriteDIBPatternDict(print_ctx *ctx, const BITMAPINFO *bmi, BYTE *bits
     else
     {
         FIXME("wrong usage: %d\n", usage);
+        HeapFree( GetProcessHeap(), 0, buf );
         return FALSE;
     }
     PSDRV_WriteRGB(ctx, map, 2);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

[Huw Davies (＠huw)]

It would be better to test for `usage > 2` near the top of the function, before any PostScript is actually written.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4664#note_56222