[PATCH 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO.

[Ziqing Hui (＠zhui)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

[PATCH 1/1] winegstreamer: Implement Flush for WMV decoder DMO.

[Ziqing Hui]

From: Ziqing Hui <zhui(a)codeweavers.com>

---
 dlls/mf/tests/transform.c        |  3 ---
 dlls/winegstreamer/wmv_decoder.c | 13 +++++++++++--
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/dlls/mf/tests/transform.c b/dlls/mf/tests/transform.c
index 1eb0fd2c719..9ba1dfc9660 100644
--- a/dlls/mf/tests/transform.c
+++ b/dlls/mf/tests/transform.c
@@ -6392,10 +6392,8 @@ static void test_wmv_decoder_media_object(void)
     hr = IMediaObject_ProcessInput(media_object, 0, &input_media_buffer->IMediaBuffer_iface, 0, 0, 0);
     ok(hr == S_OK, "ProcessInput returned %#lx.\n", hr);
     hr = IMediaObject_Flush(media_object);
-    todo_wine
     ok(hr == S_OK, "Flush returned %#lx.\n", hr);
     hr = IMediaObject_Flush(media_object);
-    todo_wine
     ok(hr == S_OK, "Flush returned %#lx.\n", hr);
     output_media_buffer->length = 0;
     output_data_buffer.pBuffer = &output_media_buffer->IMediaBuffer_iface;
@@ -6405,7 +6403,6 @@ static void test_wmv_decoder_media_object(void)
     hr = IMediaObject_ProcessOutput(media_object, 0, 1, &output_data_buffer, &status);
     todo_wine
     ok(hr == S_FALSE, "ProcessOutput returned %#lx.\n", hr);
-    todo_wine
     ok(output_media_buffer->length == 0, "Unexpected length %#lx.\n", output_media_buffer->length);
 
     /* Test ProcessOutput with setting framerate. */
diff --git a/dlls/winegstreamer/wmv_decoder.c b/dlls/winegstreamer/wmv_decoder.c
index 32dbbbbe686..d6c95cbd526 100644
--- a/dlls/winegstreamer/wmv_decoder.c
+++ b/dlls/winegstreamer/wmv_decoder.c
@@ -657,8 +657,17 @@ static HRESULT WINAPI media_object_SetInputMaxLatency(IMediaObject *iface, DWORD
 
 static HRESULT WINAPI media_object_Flush(IMediaObject *iface)
 {
-    FIXME("iface %p stub!\n", iface);
-    return E_NOTIMPL;
+    struct wmv_decoder *decoder = impl_from_IMediaObject(iface);
+    HRESULT hr;
+
+    TRACE("iface %p.\n", iface);
+
+    if (FAILED(hr = wg_transform_flush(decoder->wg_transform)))
+        return hr;
+
+    wg_sample_queue_flush(decoder->wg_sample_queue, TRUE);
+
+    return S_OK;
 }
 
 static HRESULT WINAPI media_object_Discontinuity(IMediaObject *iface, DWORD index)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

[PATCH 1/1] winegstreamer: Implement Flush for WMV decoder DMO.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=133766

Your paranoid android.


=== debian11 (32 bit report) ===

user32:
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0135 was expected, but got msg 0x030f instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 7: the msg 0x8000 was expected, but got msg 0x0086 instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 8: the msg sequence is not complete: expected 0000 - actual 0006

[PATCH 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3063

[PATCH 0/1] MR3063: winegstreamer: Implement Flush for WMV decoder DMO. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3063