[PATCH 0/1] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_path_from_p...) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737
From: Alanas <alanas.00(a)mail.ru> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 --- dlls/comctl32/toolbar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index 690a02db6ee..d12cd25715c 100644 --- a/dlls/comctl32/toolbar.c +++ b/dlls/comctl32/toolbar.c @@ -6360,7 +6360,7 @@ TOOLBAR_Notify (TOOLBAR_INFO *infoPtr, LPNMHDR lpnmh) return 0; default: - return 0; + return SendMessageW(infoPtr->hwndNotify, WM_NOTIFY, lpnmh->idFrom, (LPARAM)lpnmh); } } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6737
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=149332 Your paranoid android. === debian11b (64 bit WoW report) === user32: input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000001B100DC, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032
Could you add a test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86188
On Sun Oct 27 08:45:42 2024 +0000, Zhiyi Zhang wrote:
Could you add a test? Which `nmhdr.code`s should test try (trying every 32bit unsigned integer is slow and unsafe (there are some mysterious `nmhdr.code` handlers in windows (see most of comments in https://bugs.winehq.org/show_bug.cgi?id=57178)))?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86189
On Sun Oct 27 08:45:42 2024 +0000, Alanas wrote:
Which `nmhdr.code`s should test try (trying every 32bit unsigned integer is slow and unsafe (there are some mysterious `nmhdr.code` handlers in windows (see most of comments in https://bugs.winehq.org/show_bug.cgi?id=57178)))? Could you use the same notification code used by 7z, or maybe something like 0xdeadbeef, seeing that you're changing the default case?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86190
On Sun Oct 27 09:01:28 2024 +0000, Zhiyi Zhang wrote:
Could you use the same notification code used by 7z, or maybe something like 0xdeadbeef, seeing that you're changing the default case? note: all code blocks are links in this reply
I'm trying to understand how test code works. I found:<ul><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L2750-2752"><pre><code lang="c"> HWND hwnd; rebuild_toolbar(&hwnd);</code></pre></a></li><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L515-518"><pre><code lang="c">static void rebuild_toolbar(HWND *hToolbar) { rebuild_toolbar_ex(hToolbar, 0); }</code></pre></a></li><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L503-505"><pre><code lang="c">static void rebuild_toolbar_ex(HWND *hToolbar, DWORD exstyle) { if (*hToolbar)</code></pre></a></li></ul>Why is this code checking is uninitialized <code lang="c">sizeof(HWND)</code> bytes of stack memory all zeroes? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86204
On Sun Oct 27 18:10:54 2024 +0000, Alanas wrote:
note: all code blocks are links in this reply I'm trying to understand how test code works. I found:<ul><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L2750-2752"><pre><code lang="c"> HWND hwnd; rebuild_toolbar(&hwnd);</code></pre></a></li><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L515-518"><pre><code lang="c">static void rebuild_toolbar(HWND *hToolbar) { rebuild_toolbar_ex(hToolbar, 0); }</code></pre></a></li><li><a href="https://gitlab.winehq.org/wine/wine/-/blob/3a736901cdd588ba7fbb4318e5f5069793268a01/dlls/comctl32/tests/toolbar.c#L503-505"><pre><code lang="c">static void rebuild_toolbar_ex(HWND *hToolbar, DWORD exstyle) { if (*hToolbar)</code></pre></a></li></ul>Why is this code checking is uninitialized <code lang="c">sizeof(HWND)</code> bytes of stack memory all zeroes? That's a bug that we'll need to patch. First time it's called it's meant to get a null handle, so local variable is missing initializer here.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86205
On Sun Oct 27 18:18:49 2024 +0000, Nikolay Sivov wrote:
That's a bug that we'll need to patch. First time it's called it's meant to get a null handle, so local variable is missing initializer here. That's from test_BTNS_SEP().
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86206
participants (5)
-
Alanas -
Alanas (＠BZZZZ)
-
Marvin -
Nikolay Sivov (＠nsivov)
-
Zhiyi Zhang (＠zhiyi)