[PATCH 0/1] MR4101: uxtheme/tests: Skip the test if the SystemUsesLightTheme value isn't found.

[Helix Graziani (＠TornadoCookie)]

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55771

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4101

[PATCH 1/1] uxtheme/tests: Skip the test if the SystemUsesLightTheme value isn't found.

[Helix Graziani]

From: Helix Graziani <helix.graziani(a)hotmail.com>

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55771
---
 dlls/uxtheme/tests/system.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c
index 390baece969..da385e11e7e 100644
--- a/dlls/uxtheme/tests/system.c
+++ b/dlls/uxtheme/tests/system.c
@@ -2617,8 +2617,8 @@ static void test_ShouldSystemUseDarkMode(void)
                       L"SystemUsesLightTheme", RRF_RT_REG_DWORD, NULL, &light_theme, &light_theme_size);
     if (ls == ERROR_FILE_NOT_FOUND)
     {
-        light_theme = 1;
-        ls = 0;
+        win_skip("SystemUsesLightTheme registry value not found.\n");
+        return;
     }
     ok(ls == 0, "RegGetValue failed: %ld.\n", ls);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4101

[PATCH 1/1] uxtheme/tests: Skip the test if the SystemUsesLightTheme value isn't found.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=138759

Your paranoid android.


=== debian11 (32 bit report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit ar:MA report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit de report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit fr report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit he:IL report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit hi:IN report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit ja:JP report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11 (32 bit zh:CN report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11b (32 bit WoW report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.

=== debian11b (64 bit WoW report) ===

uxtheme:
system.c:2620: Test failed: SystemUsesLightTheme registry value not found.