Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
16 Feb
2025
16 Feb
'25
4:37 p.m.
eric pouech (@epo) commented about programs/cmd/directory.c:
}
/* Trailer Information */ - if (trailerReqd) { + if (trailerReqd && return_code == NO_ERROR) { WCMD_dir_trailer(prevEntry->dirName); }
- if (num_empty && !num_with_data) + if (return_code == STATUS_CONTROL_C_EXIT) actually, we could (later on) have other values as return code...
so IMO this should rather be written as: `if (return_code != NO_ERROR || (num_empty && !num_with_data))` ` errorlevel = ERROR_INVALID_FUNCTION;` `else` ` errorlevel = NO_ERROR;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94820
307
Age (days ago)
307
Last active (days ago)
0 comments
1 participants
participants (1)
-
eric pouech (@epo)