[PATCH v4 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef

[Ostap Brehin (＠osbre)]

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppro...

--
  v4: include: Name parameters in LPPROGRESS_ROUTINE typedef
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

[PATCH v4 1/1] include: Name parameters in LPPROGRESS_ROUTINE typedef

[Ostap Brehin]

From: Ostap Brehin <osbre(a)protonmail.com>

---
 include/winbase.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/winbase.h b/include/winbase.h
index fe143cc7a61..478f9d99e20 100644
--- a/include/winbase.h
+++ b/include/winbase.h
@@ -1035,9 +1035,11 @@ typedef struct _WIN32_FILE_ATTRIBUTES_DATA {
  * This one seems to be a Win32 only definition. It also is defined with
  * WINAPI instead of CALLBACK in the windows headers.
  */
-typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE_INTEGER,
-                                           LARGE_INTEGER, DWORD, DWORD, HANDLE,
-                                           HANDLE, LPVOID);
+typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(
+    LARGE_INTEGER total_file_size, LARGE_INTEGER total_bytes_transferred, LARGE_INTEGER stream_size,
+    LARGE_INTEGER stream_bytes_transferred, DWORD stream_number, DWORD callback_reason,
+    HANDLE source_file, HANDLE destination_file, void *user_data
+);
 
 typedef DWORD (WINAPI *APPLICATION_RECOVERY_CALLBACK)(PVOID);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

[PATCH v4 1/1] include: Name parameters in LPPROGRESS_ROUTINE typedef

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148172

Your paranoid android.


=== debian11b (64 bit WoW report) ===

ddraw:
ddraw2.c:3814: Test failed: Expected (0,0)-(640,480), got (0,0)-(1024,768).
ddraw2.c:3839: Test failed: Expected (0,0)-(640,480), got (0,0)-(1024,768).