[PATCH 0/1] MR3918: msado15: Recordset::Open - Correctly update count/index values

[Alistair Leslie-Hughes (＠alesliehughes)]

ADO can return a RecordCount of -1.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3918

[PATCH 1/1] msado15: Recordset::Open - Correctly update count/index values

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

ADO can return a RecordCount of -1.
---
 dlls/msado15/recordset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c
index 84db7fc581d..dade36bef1a 100644
--- a/dlls/msado15/recordset.c
+++ b/dlls/msado15/recordset.c
@@ -2104,8 +2104,8 @@ static HRESULT WINAPI recordset_Open( _Recordset *iface, VARIANT source, VARIANT
         return hr;
     }
 
-    recordset->count = affected;
-    recordset->index = affected ? 0 : -1;
+    recordset->count = affected > 0 ? affected : 0;
+    recordset->index = affected > 0 > 0 : -1;
 
     /*
      * We can safely just return with an empty recordset here
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3918

[PATCH 1/1] msado15: Recordset::Open - Correctly update count/index values

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=137697

Your paranoid android.


=== debian11 (build log) ===

../wine/dlls/msado15/recordset.c:2108:40: error: expected ���;��� before ���:��� token
Task: The win32 Wine build failed

=== debian11b (build log) ===

../wine/dlls/msado15/recordset.c:2108:40: error: expected ���;��� before ���:��� token
Task: The wow64 Wine build failed