[PATCH 0/1] MR1586: winex11: Fix memory leak on realloc failure in import_xdnd_selection (cppcheck).

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1586

[PATCH 1/1] winex11: Fix memory leak on realloc failure in import_xdnd_selection (cppcheck).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/winex11.drv/clipboard.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c
index 6ebc36cbead..47839e4925c 100644
--- a/dlls/winex11.drv/clipboard.c
+++ b/dlls/winex11.drv/clipboard.c
@@ -1285,7 +1285,7 @@ struct format_entry *import_xdnd_selection( Display *display, Window win, Atom s
     UINT i;
     void *data;
     struct clipboard_format *format;
-    struct format_entry *ret = NULL, *entry;
+    struct format_entry *ret = NULL, *tmp, *entry;
     BOOL have_hdrop = FALSE;
 
     register_x11_formats( targets, count );
@@ -1310,7 +1310,8 @@ struct format_entry *import_xdnd_selection( Display *display, Window win, Atom s
         entry_size = (FIELD_OFFSET( struct format_entry, data[size] ) + 7) & ~7;
         if (buf_size < size + entry_size)
         {
-            if (!(ret = realloc( ret, *ret_size + entry_size + 1024 ))) continue;
+            if (!(tmp = realloc( ret, *ret_size + entry_size + 1024 ))) continue;
+            ret = tmp;
             buf_size = *ret_size + entry_size + 1024; /* extra space for following entries */
         }
         entry = (struct format_entry *)((char *)ret + *ret_size);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1586

[PATCH 1/1] winex11: Fix memory leak on realloc failure in import_xdnd_selection (cppcheck).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126906

Your paranoid android.


=== debian11 (32 bit report) ===

winmm:
midi: Timeout

Report validation errors:
advapi32:security has no test summary line (early exit of the main process?)
advapi32:security has unaccounted for todo messages