Re: [PATCH v5 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
9 Aug
2023
9 Aug
'23
12:57 p.m.
Nikolay Sivov (@nsivov) commented about dlls/evr/sample.c:
}
IMFSample_Release(sample); - - if (allocator->callback) - IMFVideoSampleAllocatorNotify_NotifyRelease(allocator->callback); + callback = allocator->callback;
LeaveCriticalSection(&allocator->cs);
+ if (callback) + IMFVideoSampleAllocatorNotify_NotifyRelease(allocator->callback); + return S_OK;
This is public API, and NotifyRelease() is blocking on Windows. What I suggested was to create some customized version of this, just for internal use. For example conditionally, or with a different Invoke() method implementation, whatever looks better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_41781
863
Age (days ago)
863
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov (@nsivov)