Re: [PATCH v3 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
Brendan McGrath (@redmcg) commented about dlls/winedmo/unix_demuxer.c:
} format = demuxer->ctx->iformat;
- if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE) + if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE || + strstr( format->name, "mp3")) { if ((ret = avformat_find_stream_info( demuxer->ctx, NULL )) < 0) { ERR( "Failed to find stream info, error %s.\n", debugstr_averr(ret) ); goto failed; } - params->duration = get_context_duration( demuxer->ctx ); + if (params->duration == AV_NOPTS_VALUE) + params->duration = get_context_duration( demuxer->ctx );
@rbernon I wasn't sure how harmless/harmful this assignment was, so I added a check just in case. If you think it's unnecessary I'll remove. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439#note_96517
participants (1)
-
Brendan McGrath (@redmcg)