[PATCH v3 0/1] MR4788: ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.

[Alex Henrie (＠alexhenrie)]

LANCommander calls NtMapViewOfSectionEx with
alloc_type=MEM_REPLACE_PLACEHOLDER, but you couldn't tell from the
trace.

--
  v3: ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4788

[PATCH v3 1/1] ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

LANCommander calls NtMapViewOfSectionEx with
alloc_type=MEM_REPLACE_PLACEHOLDER, but you couldn't tell from the
trace.
---
 dlls/ntdll/unix/virtual.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c
index abe1b4dc4ec..d5e54a93197 100644
--- a/dlls/ntdll/unix/virtual.c
+++ b/dlls/ntdll/unix/virtual.c
@@ -5439,8 +5439,8 @@ NTSTATUS WINAPI NtMapViewOfSection( HANDLE handle, HANDLE process, PVOID *addr_p
 
     offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0;
 
-    TRACE("handle=%p process=%p addr=%p off=%s size=%lx access=%x\n",
-          handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect );
+    TRACE("handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n",
+          handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)alloc_type, (int)protect );
 
     /* Check parameters */
     if (zero_bits > 21 && zero_bits < 32)
@@ -5517,8 +5517,8 @@ NTSTATUS WINAPI NtMapViewOfSectionEx( HANDLE handle, HANDLE process, PVOID *addr
 
     offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0;
 
-    TRACE( "handle=%p process=%p addr=%p off=%s size=%lx access=%x\n",
-           handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect );
+    TRACE( "handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n",
+           handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)alloc_type, (int)protect );
 
     status = get_extended_params( parameters, count, &limit_low, &limit_high,
                                   &align, &attributes, &machine );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4788

[Alex Henrie (＠alexhenrie)]

On Sun Jan  7 21:55:54 2024 +0000, Nikolay Sivov wrote:
> If you mean MEM_REPLACE_PLACEHOLDER, wine does support it.
> You're right, 0x4000 is MEM_REPLACE_PLACEHOLDER, and the bug is a subtle one. See Dmitry's analysis at https://bugs.winehq.org/show_bug.cgi?id=56122#c1

I've updated the commit message to be more accurate.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4788#note_56852

[Felix Münchhalfen]

This is related: https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

sorry i accidentally commented in your bug report, i was meaning to mark my own bug report as closed.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4788#note_57071