[PATCH 0/1] MR7129: ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.

[Jinoh Kang (＠iamahuman)]

Use the irql assigned by IoAcquireCancelSpinLock, not the
(yet-to-be-assigned) irp->CancelIrql.

This is for readability.  No semantic change is expected with unmodified
ntoskrnl.exe/hal.dll.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

[PATCH 1/1] ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.

[Jinoh Kang]

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

Use the irql assigned by IoAcquireCancelSpinLock, not the
(yet-to-be-assigned) irp->CancelIrql.

This is for readability.  No semantic change is expected with unmodified
ntoskrnl.exe/hal.dll.
---
 dlls/ntoskrnl.exe/ntoskrnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c
index a375cd078b5..7d08ed06444 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/ntoskrnl.c
@@ -2122,7 +2122,7 @@ BOOLEAN WINAPI IoCancelIrp( IRP *irp )
     irp->Cancel = TRUE;
     if (!(cancel_routine = IoSetCancelRoutine( irp, NULL )))
     {
-        IoReleaseCancelSpinLock( irp->CancelIrql );
+        IoReleaseCancelSpinLock( irql );
         return FALSE;
     }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7129

[PATCH 1/1] ntoskrnl.exe: Fix IRQL mismatch between cancel spin lock acquire and release.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150856

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000013D00E6, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032