[PATCH 0/1] MR7267: explorerframe: Return S_OK in more ITaskbarList3 functions.
The software Helicon Filter 5 crashes at startup when it tries to call SetTabOrder and SetTabActive. And it crashes on shutdown when it tries to call UnregisterTab. Fake success return code as it was done in the following commit for some other functions already: 570ea014770fd62997be81e88f03829eded98390 <details><summary>Wine log from SetTabOrder to automatic starting of debugger</summary> <pre> 0134:fixme:explorerframe:taskbar_list_RegisterTab iface 027DE690, hwndTab 000103AC, hwndMDI 000100F0 stub! 0134:fixme:explorerframe:taskbar_list_SetTabOrder iface 027DE690, hwndTab 000103AC, hwndInsertBefore 00000000 stub! 0134:Call oleaut32.GetErrorInfo(00000000,00e6fdf4) ret=004c76b6 0134:Call combase.GetErrorInfo(00000000,00e6fdf4) ret=7bcebd50 0134:Ret combase.GetErrorInfo() retval=00000001 ret=7bcebd50 0134:Ret oleaut32.GetErrorInfo() retval=00000001 ret=004c76b6 0134:Call KERNEL32.FormatMessageA(00003200,00000000,80004001,00000000,00e6fc38,00000100,00000000) ret=0041da74 0134:Call ntdll.RtlFindMessage(7b5e0000,0000000b,00000000,80004001,00e6fb64) ret=7b65982a 0134:Ret ntdll.RtlFindMessage() retval=00000000 ret=7b65982a 0134:Call ntdll.RtlAllocateHeap(00350000,00000000,00010000) ret=7b5fcaaa 0134:Ret ntdll.RtlAllocateHeap() retval=09030020 ret=7b5fcaaa 0134:Call ntdll.RtlFormatMessage(7b76ddd0,00000000,00000001,00000001,00000001,00000000,09030020,00010000,00e6fbb4) ret=7b5fcb0a 0134:Ret ntdll.RtlFormatMessage() retval=00000000 ret=7b5fcb0a 0134:Call ntdll.RtlFreeHeap(00350000,00000000,00000000) ret=7b5fcb2f 0134:Ret ntdll.RtlFreeHeap() retval=00000001 ret=7b5fcb2f 0134:Call ntdll.RtlFreeHeap(00350000,00000000,09030020) ret=7b5fcbd6 0134:Ret ntdll.RtlFreeHeap() retval=00000001 ret=7b5fcbd6 0134:Ret KERNEL32.FormatMessageA() retval=00000011 ret=0041da74 0134:Call KERNEL32.RaiseException(0eedfade,00000001,00000007,00e6fda8) ret=0081acc3 0134:trace:seh:dispatch_exception code=eedfade (unknown) flags=1 addr=7B627448 0134:trace:seh:dispatch_exception info[0]=0081ACC3 0134:trace:seh:dispatch_exception info[1]=038A2B00 0134:trace:seh:dispatch_exception info[2]=80004001 0134:trace:seh:dispatch_exception info[3]=0081ACC3 0134:trace:seh:dispatch_exception info[4]=00000000 0134:trace:seh:dispatch_exception info[5]=00E6FDF8 0134:trace:seh:dispatch_exception info[6]=00E6FDC4 0134:trace:seh:dispatch_exception eip=7b627448 esp=00e6fd00 ebp=00e6fd58 eflags=00200246 0134:trace:seh:dispatch_exception eax=00e6fd00 ebx=00000018 ecx=00e6fd14 edx=00e6fda8 0134:trace:seh:dispatch_exception esi=00e6fdf8 edi=00e6fd70 cs=0023 ds=002b es=002b fs=0063 gs=006b ss=002b 0134:trace:seh:call_seh_handlers calling handler at 004C7770 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 004C7770 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0081ACF2 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0081ACF2 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0081B18F code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0081B18F returned 1 0134:trace:seh:call_seh_handlers calling handler at 00902C31 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 00902C31 returned 1 0134:trace:seh:call_seh_handlers calling handler at 0096B5C7 code=eedfade flags=1 0134:trace:seh:call_seh_handlers handler at 0096B5C7 returned 1 0134:trace:seh:call_seh_handlers calling handler at 004059FC code=eedfade flags=1 0134:Call KERNEL32.UnhandledExceptionFilter(00e6f118) ret=00405a20 0134:Call ntdll.NtQueryInformationProcess(ffffffff,0000000c,00e6f084,00000004,00000000) ret=7b602304 0134:Ret ntdll.NtQueryInformationProcess() retval=00000000 ret=7b602304 0134:Call ntdll.NtCreateEvent(00e6f0ac,001f0003,00e6f0b0,00000000,00000000) ret=7b642f85 0134:Ret ntdll.NtCreateEvent() retval=00000000 ret=7b642f85 wine: Unhandled exception 0x0eedfade in thread 134 at address 7B627448 (thread 0134), starting debugger... </pre> </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7267
From: Sebastian Scheibner <sebastian.scheibner(a)posteo.de> The software Helicon Filter 5 crashes at startup when it tries to call SetTabOrder and SetTabActive. And it crashes on shutdown when it tries to call UnregisterTab. Fake success return code as it was done in the following commit for some other functions: 570ea014770fd62997be81e88f03829eded98390 --- dlls/explorerframe/taskbarlist.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/explorerframe/taskbarlist.c b/dlls/explorerframe/taskbarlist.c index dd61cc62ae4..c5715e68e50 100644 --- a/dlls/explorerframe/taskbarlist.c +++ b/dlls/explorerframe/taskbarlist.c @@ -170,18 +170,18 @@ static HRESULT STDMETHODCALLTYPE taskbar_list_RegisterTab(ITaskbarList4 *iface, static HRESULT STDMETHODCALLTYPE taskbar_list_UnregisterTab(ITaskbarList4 *iface, HWND hwndTab) { - FIXME("iface %p, hwndTab %p stub!\n", iface, hwndTab); + FIXME("iface %p, hwndTab %p stub, faking success!\n", iface, hwndTab); - return E_NOTIMPL; + return S_OK; } static HRESULT STDMETHODCALLTYPE taskbar_list_SetTabOrder(ITaskbarList4 *iface, HWND hwndTab, HWND hwndInsertBefore) { - FIXME("iface %p, hwndTab %p, hwndInsertBefore %p stub!\n", iface, hwndTab, hwndInsertBefore); + FIXME("iface %p, hwndTab %p, hwndInsertBefore %p stub, faking success!\n", iface, hwndTab, hwndInsertBefore); - return E_NOTIMPL; + return S_OK; } static HRESULT STDMETHODCALLTYPE taskbar_list_SetTabActive(ITaskbarList4 *iface, @@ -189,9 +189,9 @@ static HRESULT STDMETHODCALLTYPE taskbar_list_SetTabActive(ITaskbarList4 *iface, HWND hwndMDI, DWORD dwReserved) { - FIXME("iface %p, hwndTab %p, hwndMDI %p, dwReserved %lx stub!\n", iface, hwndTab, hwndMDI, dwReserved); + FIXME("iface %p, hwndTab %p, hwndMDI %p, dwReserved %lx stub, faking success!\n", iface, hwndTab, hwndMDI, dwReserved); - return E_NOTIMPL; + return S_OK; } static HRESULT STDMETHODCALLTYPE taskbar_list_ThumbBarAddButtons(ITaskbarList4 *iface, -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7267
participants (2)
-
Sebastian Scheibner -
Sebastian Scheibner (＠sebastian)