[PATCH v2 0/1] MR2277: winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages.

[Francois Gouget (＠fgouget)]

--
  v2: winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2277

[PATCH v2 1/1] winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54557
---
 dlls/winmm/tests/midi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/winmm/tests/midi.c b/dlls/winmm/tests/midi.c
index cf58e1e955a..d6f54e75f23 100644
--- a/dlls/winmm/tests/midi.c
+++ b/dlls/winmm/tests/midi.c
@@ -39,8 +39,9 @@ extern const char* mmsys_error(MMRESULT error); /* from wave.c */
 
 static BOOL spurious_message(LPMSG msg)
 {
-  /* WM_DEVICECHANGE 0x0219 appears randomly */
-  if(msg->message == WM_DEVICECHANGE) {
+  /* These messages appear randomly */
+  if(msg->message == WM_DEVICECHANGE ||
+     msg->message == WM_DWMCOLORIZATIONCOLORCHANGED) {
     trace("skipping spurious message %04x\n", msg->message);
     return TRUE;
   }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2277

[PATCH v2 1/1] winmm/tests: Ignore spurious WM_DWMCOLORIZATIONCOLORCHANGED messages.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=129956

Your paranoid android.


=== w7u_adm (32 bit report) ===

winmm:
midi.c:1040: Test failed: bad message 1e/0 from midiStreamOut, expect 3c9/22f920
midi.c:1049: Test failed: bad message 3c9/22f920 from midiStreamClose, expect 3c8/0

=== w10pro64_zh_CN (64 bit report) ===

winmm:
midi.c:880: Test failed: expected 50ms or greater, got 106ms

[Francois Gouget (＠fgouget)]

v2: Point to bug 54557 in the commit message.
> From the bug: winmm:midi sometimes gets unexpected 0x320 messages which cause failures. If these actually correspond to WM_DWMCOLORIZATIONCOLORCHANGED then they should be ignored. Not sure why winmm:midi would receive such messages though (interference from other tests?).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2277#note_25413