[PATCH 0/1] MR8475: d3dcompiler: Don't assume that enum is unsigned in d3dcompiler_get_blob_part.
Fixes `D3D_BLOB_PART` validation tests on Clang in MSVC mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8475
From: Jacek Caban <jacek(a)codeweavers.com> Fixes D3D_BLOB_PART validation tests on Clang in MSVC mode. --- dlls/d3dcompiler_43/blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3dcompiler_43/blob.c b/dlls/d3dcompiler_43/blob.c index f5bcb5f8fa3..c875577bc21 100644 --- a/dlls/d3dcompiler_43/blob.c +++ b/dlls/d3dcompiler_43/blob.c @@ -214,7 +214,7 @@ static BOOL check_blob_part(DWORD tag, D3D_BLOB_PART part) return add; } -static HRESULT d3dcompiler_get_blob_part(const void *data, SIZE_T data_size, D3D_BLOB_PART part, UINT flags, ID3DBlob **blob) +static HRESULT d3dcompiler_get_blob_part(const void *data, SIZE_T data_size, UINT part, UINT flags, ID3DBlob **blob) { const struct vkd3d_shader_code src_dxbc = {.code = data, .size = data_size}; struct vkd3d_shader_dxbc_section_desc *sections; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/8475
Matteo Bruni (@Mystral) commented about dlls/d3dcompiler_43/blob.c:
}
if (part > D3D_BLOB_TEST_COMPILE_PERF || (part < D3D_BLOB_TEST_ALTERNATE_SHADER && part > D3D_BLOB_XNA_SHADER))
Preexisting issue, but since it's affected by this... Apparently this check was never updated since its introduction back in ec698dea6641 (and specifically to account for 6ad18ca33a73), so it should probably look like this: ```suggestion:-1+0 if (part > D3D_BLOB_TEST_COMPILE_REPORT || (part < D3D_BLOB_TEST_ALTERNATE_SHADER && part > D3D_BLOB_DEBUG_NAME)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8475#note_108555
Can I easily test this myself? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8475#note_108558
On Tue Jul 1 16:04:42 2025 +0000, Matteo Bruni wrote:
Can I easily test this myself? Yes, build Wine with `--with-mingw=clang` and run `blob.ok` tests. I will change the check as you suggested.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8475#note_108565
participants (3)
-
Jacek Caban -
Jacek Caban (@jacek) -
Matteo Bruni (@Mystral)