[PATCH 0/1] MR8265: kernelbase/tests: Make sure buffer is big enough for test paths.

[Yuxuan Shui (＠yshui)]

We have test cases with |path| > MAX_PATH, but our buffer is only MAX_PATH
sized.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8265

[PATCH 1/1] kernelbase/tests: Make sure buffer is big enough for test paths.

[Yuxuan Shui]

From: Yuxuan Shui <yshui(a)codeweavers.com>

We have test cases with |path| > MAX_PATH, but our buffer is only MAX_PATH
sized.
---
 dlls/kernelbase/tests/path.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/kernelbase/tests/path.c b/dlls/kernelbase/tests/path.c
index 62a8f7e5b4f..b6121cac794 100644
--- a/dlls/kernelbase/tests/path.c
+++ b/dlls/kernelbase/tests/path.c
@@ -1093,7 +1093,7 @@ static void test_PathCchAddExtension(void)
 
 static void test_PathCchCanonicalize(void)
 {
-    WCHAR path_inW[MAX_PATH], path_outW[MAX_PATH];
+    WCHAR path_inW[MAX_PATH + 16], path_outW[MAX_PATH];
     CHAR path_outA[MAX_PATH];
     HRESULT hr;
     INT i;
@@ -1150,7 +1150,8 @@ static void test_PathCchCanonicalize(void)
         /* Skip test cases where a flag is used */
         if (!lstrcmpA("C:", t->path_in) || t->flags) continue;
 
-        MultiByteToWideChar(CP_ACP, 0, t->path_in, -1, path_inW, ARRAY_SIZE(path_inW));
+        hr = MultiByteToWideChar(CP_ACP, 0, t->path_in, -1, path_inW, ARRAY_SIZE(path_inW));
+        ok(hr, "MultiByteToWideChar failed %#lx\n", GetLastError());
         hr = pPathCchCanonicalize(path_outW, ARRAY_SIZE(path_outW), path_inW);
         ok(hr == t->hr, "path %s expect result %#lx, got %#lx\n", t->path_in, t->hr, hr);
         if (SUCCEEDED(hr))
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8265