[PATCH 0/2] MR8935: d3d8, d3d9: Flag some failing tests as todo_wine.

[Rémi Bernon]

They are now consistently failing for every MR since the upgrade to Debian trixie.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8935

[PATCH 1/2] d3d8/tests: Flag some tests as todo_wine.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/d3d8/tests/visual.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c
index b40743f0cbb..5876aae0d90 100644
--- a/dlls/d3d8/tests/visual.c
+++ b/dlls/d3d8/tests/visual.c
@@ -237,6 +237,7 @@ static void check_rect(struct surface_readback *rb, RECT r, const char *message)
                     if (x < 0 || x >= 640 || y < 0 || y >= 480)
                         continue;
                     color = get_readback_color(rb, x, y);
+                    todo_wine_if(i == 0 && x_side == 0 && y_side == 1 && sizeof(void *) == 4)
                     ok(color == expected, "%s: Pixel (%ld, %ld) has color %08x, expected %08x.\n",
                             message, x, y, color, expected);
                 }
@@ -5130,7 +5131,7 @@ static void fog_special_test(void)
         ok(SUCCEEDED(hr), "Failed to end scene, hr %#lx.\n", hr);
 
         color = getPixelColor(device, 310, 240);
-        ok(color_match(color, tests[i].color_left, 1),
+        todo_wine_if(tests[i].vertexmode == D3DFOG_NONE) ok(color_match(color, tests[i].color_left, 1),
                 "Expected left color 0x%08x, got 0x%08x, case %u.\n", tests[i].color_left, color, i);
         color = getPixelColor(device, 330, 240);
         ok(color_match(color, tests[i].color_right, 1),
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/8935

[PATCH 2/2] d3d9/tests: Flag some tests as todo_wine.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/d3d9/tests/visual.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c
index edadc7016d4..cc2b60d0d48 100644
--- a/dlls/d3d9/tests/visual.c
+++ b/dlls/d3d9/tests/visual.c
@@ -18339,7 +18339,7 @@ static void fog_special_test(void)
         ok(SUCCEEDED(hr), "Failed to end scene, hr %#lx.\n", hr);
 
         color = getPixelColor(device, 310, 240);
-        ok(color_match(color, tests[i].color_left, 1),
+        todo_wine_if(tests[i].vertexmode == D3DFOG_NONE) ok(color_match(color, tests[i].color_left, 1),
                 "Expected left color 0x%08x, got 0x%08x, case %u.\n", tests[i].color_left, color, i);
         color = getPixelColor(device, 330, 240);
         ok(color_match(color, tests[i].color_right, 1),
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8935

[PATCH 0/2] MR8935: d3d8, d3d9: Flag some failing tests as todo_wine. - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8935

[Elizabeth Figura (＠zfigura)]

The test_viewport failure is weird in that it's 32-bit specific. Note it's also not just an imprecision thing; llvmpipe is somehow drawing white all the way to x = 0. I think it's fixed somewhere between Mesa 25.0.7 and 25.2.2, though.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8935#note_115586