Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'

[Yeshun Ye (＠yeyeshun)]

On Wed Apr 12 05:47:11 2023 +0000, Huw Davies wrote:
> There's too much going on in this commit / MR.  The changes to the
> drivers seem to be addressing a bug rather than implementing the
> Endpoint Volume API.
> Also, note that the values passed to the non-`Scalar` API are in
> decibels, the `Scalar` API appears to be somewhere between linear and
> logrithmic, and the `ISimpleAudioVolume` values are linear.
> Does your app call the `Scalar` versions of the API?  If so, a good
> start would be to write some tests to figure out the mapping between
> `Scalar` and non-`Scalar` by e.g. setting using one and retreiving that
> value using the other.
> Yes, I'm fixing a bug of an application, not implementing the set of Endpoint Volume API.    
> Do I really need to write some tests?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_29674