Re: [PATCH v2 0/4] MR5161: d3drm: Implement Update and related functions
28 Feb
2024
28 Feb
'24
11:16 a.m.
Stefan Dösinger (@stefan) commented about dlls/d3drm/device.c:
}
object->primary_surface = primary_surface; - object->clipper = clipper; - IDirectDrawClipper_AddRef(clipper);
I am wondering if this breaks the tests (test_create_device_from_clipper1 checks the refcount), but the IDirectDrawSurface::SetClipper holds a reference itself. So we're probably fine with not holding a ref ourselves, especially if we don't use the clipper object anywhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5161#note_62907
736
Age (days ago)
736
Last active (days ago)
0 comments
1 participants
participants (1)
-
Stefan Dösinger