[PATCH 0/1] MR1259: gitlab: Run some tests with nulldrv driver.

[Rémi Bernon]

Allowing the job to fail to avoid failing the pipeline. Some new tests
are failing with it, and some are succeeding todo_wine.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

[PATCH 1/1] gitlab: Run some tests with nulldrv driver.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

Allowing the job to fail to avoid failing the pipeline. Some new tests
are failing with it, and some are succeeding todo_wine.
---
 tools/gitlab/test.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tools/gitlab/test.yml b/tools/gitlab/test.yml
index d2b1966ad6e..0bae73a3e4f 100644
--- a/tools/gitlab/test.yml
+++ b/tools/gitlab/test.yml
@@ -40,6 +40,7 @@
     - ln -sf $BASEDIR/wine-mono-$MONO_VER-x86.msi usr/local/share/wine/mono
     - pulseaudio --start --exit-idle-time=-1
     - wine wineboot.exe -u
+    - wine reg add HKCU\\Software\\Wine\\Drivers /v Graphics /d mac,x11,null /f
     - wineserver -w
 
 test-linux-32:
@@ -54,6 +55,20 @@ test-linux-32:
     - export WINETEST_COLOR=1
     - wine usr/local/lib/wine/i386-windows/winetest.exe -q -q -o - -t gitlab -u $CI_JOB_URL -n $EXCLUDE_TESTS
 
+test-nulldrv-64:
+  extends: .wine-test
+  variables:
+    INCLUDE_TESTS: user32
+  rules:
+    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
+  needs:
+    - job: build-linux
+  allow_failure: true
+  script:
+    - export DISPLAY=
+    - export WINETEST_COLOR=1
+    - wine usr/local/lib/wine/x86_64-windows/winetest.exe -q -q -o - -t gitlab -u $CI_JOB_URL $INCLUDE_TESTS
+
 debian-32:
   extends: .wine-test
   rules:
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

[PATCH 1/1] gitlab: Run some tests with nulldrv driver.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125759

Your paranoid android.


=== debian11 (32 bit report) ===

ddraw:
ddraw4.c:17853: Test succeeded inside todo block: Got unexpected caps 0x3046737c.
ddraw4.c:17882: Test failed: Got unexpected caps 0x3046737c.

[Rémi Bernon]

Well the pipeline failed for some unrelated reason (xaudio test which should be marked flaky probably), but this shows the idea. The https://gitlab.winehq.org/rbernon/wine/-/jobs/4242 run shows the nulldrv differences and thus what's broken in user32 vs what is fixed / broken by winex11.

It adds a few minutes overall, so I don't think it's too bad, and it would be nice to have to better test user32 changes.

Note that I think the way I'm doing allowing nulldrv to be used here may not be great as it changes the registry for all tests, and so a normal run may now fail to load winex11 and fallback to nulldrv. Maybe it's not too much of an issue as other things will likely then fail, but still an open question.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1259#note_13183

[Rémi Bernon]

It apparently also makes the global MR status appear as a warning, so that may not ideal.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1259#note_13194