[PATCH 0/1] MR7677: win32u: Always set DriverVersion.

[Sven Baars (＠sbaars)]

I think this should fix the recent wbemprox:query test failures. The alternative would be to accept NULL in the test.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7677

[PATCH 1/1] win32u: Always set DriverVersion.

[Sven Baars]

From: Sven Baars <sbaars(a)codeweavers.com>

---
 dlls/win32u/sysparams.c | 41 +++++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 22 deletions(-)

diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c
index 447b699f051..e33ff6e60e5 100644
--- a/dlls/win32u/sysparams.c
+++ b/dlls/win32u/sysparams.c
@@ -1220,30 +1220,27 @@ static BOOL write_gpu_to_registry( const struct gpu *gpu, const struct pci_id *p
     value = (ULONG)min( memory_size, (ULONGLONG)ULONG_MAX );
     set_reg_value( hkey, memory_sizeW, REG_DWORD, &value, sizeof(value) );
 
-    if (pci->vendor)
+    /* The last seven digits are the driver number. */
+    switch (pci->vendor)
     {
-        /* The last seven digits are the driver number. */
-        switch (pci->vendor)
-        {
-        /* Intel */
-        case 0x8086:
-            strcpy( buffer, "31.0.101.4576" );
-            break;
-        /* AMD */
-        case 0x1002:
-            strcpy( buffer, "31.0.14051.5006" );
-            break;
-        /* Nvidia */
-        case 0x10de:
-            strcpy( buffer, "31.0.15.3625" );
-            break;
-        /* Default value for any other vendor. */
-        default:
-            strcpy( buffer, "31.0.10.1000" );
-            break;
-        }
-        set_reg_ascii_value( hkey, "DriverVersion", buffer );
+    /* Intel */
+    case 0x8086:
+        strcpy( buffer, "31.0.101.4576" );
+        break;
+    /* AMD */
+    case 0x1002:
+        strcpy( buffer, "31.0.14051.5006" );
+        break;
+    /* Nvidia */
+    case 0x10de:
+        strcpy( buffer, "31.0.15.3625" );
+        break;
+    /* Default value for any other vendor. */
+    default:
+        strcpy( buffer, "31.0.10.1000" );
+        break;
     }
+    set_reg_ascii_value( hkey, "DriverVersion", buffer );
 
     NtClose( hkey );
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7677

[PATCH 0/1] MR7677: win32u: Always set DriverVersion. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7677

[PATCH 0/1] MR7677: Draft: win32u: Always set DriverVersion.

[Sven Baars (＠sbaars)]

It seems like this causes new failures in mf:mf and quartz:filtergraph.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7677#note_99227

[Sven Baars (＠sbaars)]

On Thu Mar 27 11:24:22 2025 +0000, Sven Baars wrote:
> It seems like this causes new failures in mf:mf and quartz:filtergraph.
> Never mind. I reran the tests and they disappeared. So I assume they were random pre-existing failures.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7677#note_99229