Re: [PATCH v10 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
On Fri Nov 18 23:01:41 2022 +0000, Esme Povirk wrote:
Yeah, this might need to be broken into smaller MRs. The questions I generally ask in a situation like this one, where we know it's not quite right yet are: How hard is it to implement correctly? And will taking the shortcut make it more difficult to implement correctly without causing regressions? I don't think it should be too difficult to create a pen object and pass it to GdipWidenPath, nor will taking the shortcut make it harder to fix later. With that in mind, I would be willing to settle for this, but it'd be good to have a comment or fixme so we know the current approach isn't right. We might find that the outline codepath is rarely-used to begin with and never bother. Using GdipWidenPath is nice idea and it shouldn't be hard to implement. It will give Line Joints support for Caps by default. I am only worried about performance (e.g. there is some matrix transformation).
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16464
participants (1)
-
Bartosz Kosiorek (@gang65)