Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
Esme Povirk (@madewokherd) commented about dlls/gdiplus/tests/image.c:
expect(InvalidParameter, stat);
+ stat = pGdipSetEffectParameters(effect, params, 0); + expect(InvalidParameter, stat); + effect = (CGpEffect *)0xdeadbeef; stat = pGdipCreateEffect(noneffect, &effect); expect(Win32Error, stat); ok(effect == NULL, "Expected effect to be NULL\n");
+ stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 0); + expect(InvalidParameter, stat); + stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 8); + expect(InvalidParameter, stat); + stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 5); + expect(InvalidParameter, stat);
Don't pass in effect by name if it's expected to be NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58653
participants (1)
-
Esme Povirk (@madewokherd)