[PATCH 0/1] MR1061: wbemprox: Add HyperVisorPresent property to win32_ComputerSystem.

[Louis Lenders (＠xe)]

Native Access 2 queries for this property

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1061

[PATCH 1/1] wbemprox: Add HyperVisorPresent property to win32_ComputerSystem.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Native Access 2 queries for this property
---
 dlls/wbemprox/builtin.c     |  3 +++
 dlls/wbemprox/tests/query.c | 11 +++++++++++
 2 files changed, 14 insertions(+)

diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c
index 820fb61930f..993ba962bfa 100644
--- a/dlls/wbemprox/builtin.c
+++ b/dlls/wbemprox/builtin.c
@@ -100,6 +100,7 @@ static const struct column col_compsys[] =
     { L"Description",               CIM_STRING },
     { L"Domain",                    CIM_STRING },
     { L"DomainRole",                CIM_UINT16 },
+    { L"HypervisorPresent",         CIM_BOOLEAN},
     { L"Manufacturer",              CIM_STRING },
     { L"Model",                     CIM_STRING },
     { L"Name",                      CIM_STRING|COL_FLAG_DYNAMIC },
@@ -541,6 +542,7 @@ struct record_computersystem
     const WCHAR *description;
     const WCHAR *domain;
     UINT16       domainrole;
+    int          hypervisorpresent;
     const WCHAR *manufacturer;
     const WCHAR *model;
     const WCHAR *name;
@@ -1669,6 +1671,7 @@ static enum fill_status fill_compsys( struct table *table, const struct expr *co
     rec->description            = L"AT/AT COMPATIBLE";
     rec->domain                 = L"WORKGROUP";
     rec->domainrole             = 0; /* standalone workstation */
+    rec->hypervisorpresent      = 0;
     rec->manufacturer           = get_compsysproduct_vendor( buf, len );
     rec->model                  = get_compsysproduct_name( buf, len );
     rec->name                   = get_computername();
diff --git a/dlls/wbemprox/tests/query.c b/dlls/wbemprox/tests/query.c
index 6c66fd93d95..12bc42d249c 100644
--- a/dlls/wbemprox/tests/query.c
+++ b/dlls/wbemprox/tests/query.c
@@ -751,6 +751,17 @@ static void test_Win32_ComputerSystem( IWbemServices *services )
         trace( "numlogicalprocessors %ld\n", V_I4( &value ) );
     }
 
+    type = 0xdeadbeef;
+    VariantInit( &value );
+    hr = IWbemClassObject_Get( obj, L"HypervisorPresent", 0, &value, &type, NULL );
+    ok( hr == S_OK || broken(hr == WBEM_E_NOT_FOUND) /* win7 testbot */, "got %#lx\n", hr );
+    if (hr == S_OK)
+    {
+        ok( V_VT( &value ) == VT_BOOL, "unexpected variant type %#x\n", V_VT( &value ) );
+        ok( type == CIM_BOOLEAN, "unexpected type %#lx\n", type );
+        trace( "HypervisorPresent %d\n", V_BOOL( &value ) );
+    }
+
     check_property( obj, L"NumberOfProcessors", VT_I4, CIM_UINT32 );
     check_property( obj, L"SystemType", VT_BSTR, CIM_STRING );
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1061

[PATCH 1/1] wbemprox: Add HyperVisorPresent property to win32_ComputerSystem.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=124985

Your paranoid android.


=== debian11 (32 bit report) ===

ddraw:
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000.
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000.

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24765.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24765.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24765.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c:
> { L"Description",               CIM_STRING },
>      { L"Domain",                    CIM_STRING },
>      { L"DomainRole",                CIM_UINT16 },
> +    { L"HypervisorPresent",         CIM_BOOLEAN},

Could you add a space before } as suggested earlier?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1061#note_10652

[Alexandre Julliard (＠julliard)]

Superseded by !1064. Next time please update the branch instead of creating a new merge request.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1061#note_10748

[PATCH 0/1] MR1061: wbemprox: Add HyperVisorPresent property to win32_ComputerSystem. - closed

[Alexandre Julliard (＠julliard)]

This merge request was closed by Alexandre Julliard.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1061