[PATCH 0/1] MR6282: odbc32: Driver can be mixed case.
From: Daniel Lehman <dlehman25(a)gmail.com> --- dlls/odbc32/proxyodbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/odbc32/proxyodbc.c b/dlls/odbc32/proxyodbc.c index bbb0e1702ae..7674df7a907 100644 --- a/dlls/odbc32/proxyodbc.c +++ b/dlls/odbc32/proxyodbc.c @@ -4283,7 +4283,7 @@ static const WCHAR *get_datasource( const struct attribute_list *list ) static WCHAR *get_drivername( const struct attribute_list *list ) { UINT32 i; - for (i = 0; i < list->count; i++) if (!wcscmp( list->attrs[i]->name, L"DRIVER" )) return list->attrs[i]->value; + for (i = 0; i < list->count; i++) if (!wcsicmp( list->attrs[i]->name, L"DRIVER" )) return list->attrs[i]->value; return NULL; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6282
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=147759 Your paranoid android. === debian11b (64 bit WoW report) === user32: input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000001C000D2, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032 Report validation errors: winmm:mci crashed (c0000008)
In fact all keywords are case insensitive. How about !6284? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6282#note_78801
This merge request was closed by Daniel Lehman. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6282
yeah, that works -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6282#note_78921
participants (4)
-
Daniel Lehman -
Daniel Lehman (＠dlehman25)
-
Hans Leidekker (＠hans)
-
Marvin