Re: [PATCH 0/1] MR126: Draft: ddraw: Limit max texture size to fit a 16bit signed integer

[Fabian Maurer (＠DarkShadow44)]

On Thu Jun  2 16:39:03 2022 +0000, Ghost User wrote:
> Henri Verbeet replied on the mailing list:
> ```
> On Thu, 2 Jun 2022 at 17:39, Fabian Maurer (@DarkShadow44)
> <wine(a)gitlab.winehq.org> wrote:
> > On Thu Jun  2 13:17:37 2022 +0000, **** wrote:
> > > Henri Verbeet replied on the mailing list:
> > > \`\`\`
> > > On Wed, 25 May 2022 at 02:02, Fabian Maurer <wine(a)gitlab.winehq.org> wrote:
> > > > Since ddraw propably never allowed sizes that big anyways,
> > > > this should not cause any issues.
> > > > This seems like something it would be easy to write tests for.
> > > > \`\`\`
> > > > Those tests would only work if your GPU advertises 32768x32768
> > > > textures though. Would the testbot be able to handle that?
> > > > I suspect not, even feature level 12_1 only requires 16384 as maximum
> > > > texture dimensions. But a test testing that ddraw never advertises
> > > > dwMaxTextureWidth/dwMaxTextureHeight larger than 16384 would still
> > > > pass there. You'd need such a GPU to verify the change is in fact
> > > > correct, but presumably you already did that.
> Not quite sure how to continue here, my current GPU doesn't seem to allow texture sizes over 16384x16384. Not sure how to do proper testing like this.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/126#note_10821