[PATCH 0/1] MR643: configure: Downgrade -Wincompatible-function-pointer-types to a warning on ARM
Clang 16 is defaulting -Wincompatible-function-pointer-types to an error instead of a warning. This isn't an issue for most of Wine, but the error shows up in a lot of cases if doing a non-PE build for ARM (32 bit, 64 has no such issues), in particular around the integration of libxml2 and faudio. The root cause of the issue is that some functions are specified with e.g. __attribute__((pcs("aapcs-vfp"))) - which is equal to the default calling convention when compiling with -mfloat-abi=hard - but Clang's warning doesn't treat such function pointers as equal. (This could maybe be considered a bug or limitation in Clang though.) There's also some smaller amount of cases where our attributes actually do conflict, where we mix __attribute__((pcs("aapcs"))), i.e. arm softfloat calling convention, with the default calling convention (which is set to hardfloat), but they drown in the noise from the other ones. Therefore, on arm, try to downgrade this diagnostic back to a warning, not an error - while keeping the warnings visible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/643
From: Martin Storsjö <martin(a)martin.st> Clang 16 is defaulting -Wincompatible-function-pointer-types to an error instead of a warning. This isn't an issue for most of Wine, but the error shows up in a lot of cases if doing a non-PE build for ARM (32 bit, 64 has no such issues), in particular around the integration of libxml2 and faudio. The root cause of the issue is that some functions are specified with e.g. __attribute__((pcs("aapcs-vfp"))) - which is equal to the default calling convention when compiling with -mfloat-abi=hard - but Clang's warning doesn't treat such function pointers as equal. (This could maybe be considered a bug or limitation in Clang though.) There's also some smaller amount of cases where our attributes actually do conflict, where we mix __attribute__((pcs("aapcs"))), i.e. arm softfloat calling convention, with the default calling convention (which is set to hardfloat), but they drown in the noise from the other ones. Therefore, on arm, try to downgrade this diagnostic back to a warning, not an error - while keeping the warnings visible. Signed-off-by: Martin Storsjö <martin(a)martin.st> --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index dd4abd39e32..560d66c46de 100644 --- a/configure.ac +++ b/configure.ac @@ -1931,6 +1931,8 @@ int a(int b, ...) { __builtin_ms_va_list list; __builtin_ms_va_start(list,b); }] fi MSVCRTFLAGS="$MSVCRTFLAGS -mabi=ms" ;; esac ;; + arm*) + WINE_TRY_CFLAGS([-Wincompatible-function-pointer-types],[EXTRACFLAGS="$EXTRACFLAGS -Wno-error=incompatible-function-pointer-types"]) ;; esac CFLAGS=$saved_CFLAGS -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/643
participants (1)
-
Martin Storsjö