[PATCH 0/1] MR1761: winedbg: Avoid passing a non allocated buffer to HeapFree.

[eric pouech (＠epo)]

Latest changes to heap management can lead to a crash in this situation.

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1761

[PATCH 1/1] winedbg: Avoid passing a non allocated buffer to HeapFree.

[Eric Pouech]

From: Eric Pouech <eric.pouech(a)gmail.com>

Latest changes to heap management can lead to a crash in this situation.

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
---
 programs/winedbg/types.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/programs/winedbg/types.c b/programs/winedbg/types.c
index be13c38a158..5f5f1346c67 100644
--- a/programs/winedbg/types.c
+++ b/programs/winedbg/types.c
@@ -820,7 +820,8 @@ BOOL types_print_type(const struct dbg_type* type, BOOL details, const WCHAR* va
     }
     if (varname && !printed) dbg_printf(" %ls", varname);
 
-    HeapFree(GetProcessHeap(), 0, ptr);
+    if (name == ptr)
+        HeapFree(GetProcessHeap(), 0, ptr);
     return TRUE;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1761