[PATCH 0/1] MR4410: uiribbon: Fix IUIFramework::SetUICommandProperty() prototype.

[Zhiyi Zhang (＠zhiyi)]

The last parameter should be REFPROPVARIANT instead of PROPVARIANT.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4410

[PATCH 1/1] uiribbon: Fix IUIFramework::SetUICommandProperty() prototype.

[Zhiyi Zhang]

From: Zhiyi Zhang <zzhang(a)codeweavers.com>

The last parameter should be REFPROPVARIANT instead of PROPVARIANT.
---
 dlls/uiribbon/uiribbon.c | 4 ++--
 include/uiribbon.idl     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/uiribbon/uiribbon.c b/dlls/uiribbon/uiribbon.c
index 38fd60cd533..73682019cea 100644
--- a/dlls/uiribbon/uiribbon.c
+++ b/dlls/uiribbon/uiribbon.c
@@ -111,9 +111,9 @@ static HRESULT WINAPI UIRibbonFrameworkImpl_GetUICommandProperty(IUIFramework *i
     return E_NOTIMPL;
 }
 
-static HRESULT WINAPI UIRibbonFrameworkImpl_SetUICommandProperty(IUIFramework *iface, UINT32 commandId, REFPROPERTYKEY key, PROPVARIANT value)
+static HRESULT WINAPI UIRibbonFrameworkImpl_SetUICommandProperty(IUIFramework *iface, UINT32 commandId, REFPROPERTYKEY key, REFPROPVARIANT value)
 {
-    FIXME("(%u, %p): stub!\n", commandId, key);
+    FIXME("(%u, %p, %p): stub!\n", commandId, key, value);
 
     return E_NOTIMPL;
 }
diff --git a/include/uiribbon.idl b/include/uiribbon.idl
index d67e5cdbd5c..41fa5394c17 100644
--- a/include/uiribbon.idl
+++ b/include/uiribbon.idl
@@ -171,7 +171,7 @@ interface IUIFramework : IUnknown
     HRESULT SetUICommandProperty(
         [in] UINT32 commandId,
         [in] REFPROPERTYKEY key,
-        [in] PROPVARIANT value
+        [in] REFPROPVARIANT value
     );
     HRESULT InvalidateUICommand(
         [in] UINT32 commandId,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4410