[PATCH 0/1] MR4072: advapi32/tests: Mark some ReadEventLog tests broken on Win10 200[49].

[Daniel Lehman (＠dlehman25)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55731

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4072

[PATCH 1/1] advapi32/tests: Mark some ReadEventLog tests broken on Win10 200[49].

[Daniel Lehman]

From: Daniel Lehman <dlehman25(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55731
---
 dlls/advapi32/tests/eventlog.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/dlls/advapi32/tests/eventlog.c b/dlls/advapi32/tests/eventlog.c
index e2334c692e5..25372009b60 100644
--- a/dlls/advapi32/tests/eventlog.c
+++ b/dlls/advapi32/tests/eventlog.c
@@ -1333,11 +1333,13 @@ static void test_eventlog_start(void)
 
     handle = OpenEventLogW(0, L"System");
     handle2 = OpenEventLogW(0, L"System");
-    todo_wine ok(handle != handle2, "Expected different handle\n");
+    todo_wine
+    ok(handle != handle2 || broken(handle == handle2) /* Win10 200[49] */,
+        "Expected different handle\n");
     CloseEventLog(handle2);
 
     handle2 = OpenEventLogW(0, L"SYSTEM");
-    ok(!!handle2, "Expected valid handle\n");
+    ok(!!handle2 || broken(!handle2) /* Win10 200[49] */, "Expected valid handle\n");
     CloseEventLog(handle2);
 
     ret = TRUE;
@@ -1391,7 +1393,8 @@ static void test_eventlog_start(void)
         }
         free(record);
     }
-    todo_wine ok(found, "EventlogStarted event not found\n");
+    todo_wine
+    ok(found || broken(!found) /* Win10 200[49] */, "EventlogStarted event not found\n");
     CloseEventLog(handle);
     free(localcomputer);
 
@@ -1402,7 +1405,9 @@ static void test_eventlog_start(void)
 
     handle = OpenEventLogA(0, "System");
     handle2 = OpenEventLogA(0, "SYSTEM");
-    todo_wine ok(handle != handle2, "Expected different handle\n");
+    todo_wine
+    ok(handle != handle2 || broken(handle == handle2) /* Win10 200[49] */,
+        "Expected different handle\n");
     CloseEventLog(handle2);
 
     ret = TRUE;
@@ -1455,7 +1460,8 @@ static void test_eventlog_start(void)
         }
         free(record);
     }
-    todo_wine ok(found, "EventlogStarted event not found\n");
+    todo_wine
+    ok(found || broken(!found) /* Win10 200[49] */, "EventlogStarted event not found\n");
     CloseEventLog(handle);
     free(localcomputerA);
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4072

[Alexandre Julliard (＠julliard)]

This is making the tests meaningless. You should simply skip if the log can't be opened, like the other tests already do.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4072#note_48381