[PATCH 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt().

[Aida Jonikienė]

OpenImageViewer also requires some __std_tzdb functions to make
the image properties menu work (but that is for another MR).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

[PATCH 1/1] msvcp140_atomic_wait: Implement __std_*_crt().

[Aida Jonikienė]

From: Aida Jonikienė <aidas957(a)gmail.com>

OpenImageViewer calls these functions when triggering the image
properties menu.
---
 dlls/msvcp140_atomic_wait/main.c                    | 10 ++++++++++
 dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/dlls/msvcp140_atomic_wait/main.c b/dlls/msvcp140_atomic_wait/main.c
index b7aa30200ff..52ecae486eb 100644
--- a/dlls/msvcp140_atomic_wait/main.c
+++ b/dlls/msvcp140_atomic_wait/main.c
@@ -165,3 +165,13 @@ void __stdcall __std_release_shared_mutex_for_instance(void *ptr)
     }
     LeaveCriticalSection(&shared_mutex_cs);
 }
+
+void* __stdcall __std_calloc_crt(size_t count, size_t size)
+{
+    return calloc(count, size);
+}
+
+void __stdcall __std_free_crt(void *ptr)
+{
+    free(ptr);
+}
diff --git a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec
index 5d9dd5c1a74..88ed59adad9 100644
--- a/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec
+++ b/dlls/msvcp140_atomic_wait/msvcp140_atomic_wait.spec
@@ -12,12 +12,12 @@
 @ stub __std_atomic_wait_get_remaining_timeout
 @ stub __std_atomic_wait_indirect
 @ stdcall __std_bulk_submit_threadpool_work(ptr long)
-@ stub __std_calloc_crt
+@ stdcall __std_calloc_crt(long long)
 @ stdcall __std_close_threadpool_work(ptr)
 @ stdcall __std_create_threadpool_work(ptr ptr ptr)
 @ stub __std_execution_wait_on_uchar
 @ stub __std_execution_wake_by_address_all
-@ stub __std_free_crt
+@ stdcall __std_free_crt(ptr)
 @ stdcall __std_parallel_algorithms_hw_threads()
 @ stdcall __std_release_shared_mutex_for_instance(ptr)
 @ stdcall __std_submit_threadpool_work(ptr)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

[PATCH 1/1] msvcp140_atomic_wait: Implement __std_*_crt().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=145335

Your paranoid android.


=== debian11b (64 bit WoW report) ===

vulkan-1:
vulkan: Timeout

[PATCH 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt(). - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5565