[PATCH 0/1] MR2728: gdiplus: Traverse and draw the whole string

[David Kahurani (＠kahurani)]

There are a few things that are wrong with the handling of new lines in this code.

However, this particular code pretty much stands out as being wrong, and fixing fixes the issue that the OP is talking about in the bug report.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45698

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2728

[PATCH 1/1] gdiplus: Traverse and draw the whole string

[David Kahurani]

From: David Kahurani <k.kahurani(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45698
Signed-off-by: David Kahurani <k.kahurani(a)gmail.com>
---
 dlls/gdiplus/graphicspath.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/gdiplus/graphicspath.c b/dlls/gdiplus/graphicspath.c
index 2e30300e348..656069d7ffe 100644
--- a/dlls/gdiplus/graphicspath.c
+++ b/dlls/gdiplus/graphicspath.c
@@ -908,7 +908,7 @@ static GpStatus format_string_callback(HDC dc,
     if (y + bounds->Height * args->scale > args->maxY)
         args->maxY = y + bounds->Height * args->scale;
 
-    for (i = index; i < length; ++i)
+    for (i = index; i < length + index; ++i)
     {
         GLYPHMETRICS gm;
         TTPOLYGONHEADER *ph = NULL, *origph;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2728

[PATCH 1/1] gdiplus: Traverse and draw the whole string

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=132297

Your paranoid android.


=== debian11 (32 bit report) ===

wininet:
http: Timeout

[PATCH 0/1] MR2728: gdiplus: Traverse and draw the whole string - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2728