[PATCH 0/1] MR7556: wmp: Check the return value of IOleClientSite_QueryInterface().

[Yongjie Yao (＠yaoyongjie)]

It should be assigned to hres before checking hres as "if (FAILED(hres)) xxx".

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7556

[PATCH 1/1] wmp: Check the return value of IOleClientSite_QueryInterface().

[yaoyongjie]

From: yaoyongjie <yaoyongjie(a)uniontech.com>

---
 dlls/wmp/oleobj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wmp/oleobj.c b/dlls/wmp/oleobj.c
index e227f91f8ba..5309194f289 100644
--- a/dlls/wmp/oleobj.c
+++ b/dlls/wmp/oleobj.c
@@ -157,7 +157,7 @@ static HRESULT activate_inplace(WindowsMediaPlayer *This)
         IOleInPlaceSiteEx_OnInPlaceActivateEx(ipsiteex, &redraw, 0);
         ipsite = (IOleInPlaceSite*)ipsiteex;
     }else {
-        IOleClientSite_QueryInterface(This->client_site, &IID_IOleInPlaceSite, (void**)&ipsite);
+        hres = IOleClientSite_QueryInterface(This->client_site, &IID_IOleInPlaceSite, (void**)&ipsite);
         if(FAILED(hres)) {
             FIXME("No IOleInPlaceSite instance\n");
             return hres;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7556

[PATCH 0/1] MR7556: wmp: Check the return value of IOleClientSite_QueryInterface(). - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7556