[PATCH 0/1] MR2128: ntdll/tests: Remove some Vista broken broken(<constant>) calls.

[Michael Stefaniuc (＠mstefani)]

One of them still needs a broken() for some Win8 machines.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2128

[PATCH 1/1] ntdll/tests: Remove some Vista broken broken(<constant>) calls.

[Michael Stefaniuc]

From: Michael Stefaniuc <mstefani(a)winehq.org>

One of them still needs a broken() for some Win8 machines.
---
 dlls/ntdll/tests/info.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c
index 192f6be7ce9..9f50abc97ee 100644
--- a/dlls/ntdll/tests/info.c
+++ b/dlls/ntdll/tests/info.c
@@ -199,7 +199,7 @@ static void test_query_basic(void)
             "info is different\n" );
     }
 #else
-    ok( status == STATUS_INVALID_INFO_CLASS || broken(STATUS_NOT_IMPLEMENTED), /* vista */
+    ok( status == STATUS_INVALID_INFO_CLASS || broken(status == S_OK), /* some Win8 */
         "got %08lx\n", status);
     status = pRtlGetNativeSystemInformation( SystemNativeBasicInformation, &sbi3, sizeof(sbi3), &ReturnLength );
     ok( !status || status == STATUS_INFO_LENGTH_MISMATCH ||
@@ -3219,9 +3219,9 @@ static void test_ThreadEnableAlignmentFaultFixup(void)
 
     dummy = 0;
     status = NtQueryInformationThread( GetCurrentThread(), ThreadEnableAlignmentFaultFixup, &dummy, sizeof(ULONG), NULL );
-    ok( status == STATUS_INVALID_INFO_CLASS || broken(STATUS_NOT_IMPLEMENTED), "Expected STATUS_INVALID_INFO_CLASS, got %08lx\n", status );
+    ok( status == STATUS_INVALID_INFO_CLASS, "Expected STATUS_INVALID_INFO_CLASS, got %08lx\n", status );
     status = NtQueryInformationThread( GetCurrentThread(), ThreadEnableAlignmentFaultFixup, &dummy, 1, NULL );
-    ok( status == STATUS_INVALID_INFO_CLASS || broken(STATUS_NOT_IMPLEMENTED), "Expected STATUS_INVALID_INFO_CLASS, got %08lx\n", status );
+    ok( status == STATUS_INVALID_INFO_CLASS, "Expected STATUS_INVALID_INFO_CLASS, got %08lx\n", status );
 
     dummy = 1;
     status = pNtSetInformationThread( GetCurrentThread(), ThreadEnableAlignmentFaultFixup, &dummy, sizeof(ULONG) );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2128

[Alex Henrie (＠alexhenrie)]

I thought we still cared about XP and later (that's what the testbot supports). Has that changed?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2128#note_23488