[PATCH v2 0/1] MR242: configure: Include an atomic ordering parameter when checking __atomic_exchange_n() support.
-- v2: configure: Pass the correct number of parameters for the __atomic_exchange_n() check. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242
From: Conor McCarthy <cmccarthy(a)codeweavers.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c69d87094..2e8c4b0c2 100644 --- a/configure.ac +++ b/configure.ac @@ -143,7 +143,7 @@ VKD3D_CHECK_FUNC([HAVE_BUILTIN_ADD_OVERFLOW], [__builtin_add_overflow], [__built VKD3D_CHECK_FUNC([HAVE_SYNC_ADD_AND_FETCH], [__sync_add_and_fetch], [__sync_add_and_fetch((int *)0, 0)]) VKD3D_CHECK_FUNC([HAVE_SYNC_SUB_AND_FETCH], [__sync_sub_and_fetch], [__sync_sub_and_fetch((int *)0, 0)]) VKD3D_CHECK_FUNC([HAVE_SYNC_BOOL_COMPARE_AND_SWAP], [__sync_bool_compare_and_swap], [__sync_bool_compare_and_swap((int *)0, 0, 0)]) -VKD3D_CHECK_FUNC([HAVE_ATOMIC_EXCHANGE_N], [__atomic_exchange_n], [__atomic_exchange_n((int *)0, 0)]) +VKD3D_CHECK_FUNC([HAVE_ATOMIC_EXCHANGE_N], [__atomic_exchange_n], [__atomic_exchange_n((int *)0, 0, 0)]) dnl Makefiles case $host_os in -- GitLab https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242
On Sun Jun 25 22:42:26 2023 +0000, Zebediah Figura wrote:
Not Conor, but I'm confused, what do you mean by context? The function takes 3 parameters so the current check always fails. I changed the commit message and also replaced the atomic ordering enum value with 0 which satisfies the requirement to compile and link.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242#note_36739
This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242
This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/242
participants (4)
-
Conor McCarthy -
Conor McCarthy (＠cmccarthy)
-
Giovanni Mascellani (＠giomasce)
-
Henri Verbeet (＠hverbeet)