[PATCH v6 0/2] MR2552: wineboot: Add env variable to hide wait window

[Isaac Marovitz (＠IsaacMarovitz)]

Add a new environment variable `WINEBOOT_HIDE_DIALOG` to disable configuration wait windows. Useful for wine wrappers that want to keep the UX seamless.

--
  v6: Change `WINEHIDEWAIT` to `WINEBOOT_HIDE_DIALOG`
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2552

[PATCH v6 1/2] Add env variable to hide wait window

[Isaac Marovitz]

From: Isaac Marovitz <isaacryu(a)icloud.com>

Fix oopsie

Check if null

3rd times the charm

Diff
---
 programs/wineboot/wineboot.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c
index c05ce580298..14fd9f0c5dc 100644
--- a/programs/wineboot/wineboot.c
+++ b/programs/wineboot/wineboot.c
@@ -1341,7 +1341,10 @@ static HWND show_wait_window(void)
 {
     HWND hwnd = CreateDialogParamW( GetModuleHandleW(0), MAKEINTRESOURCEW(IDD_WAITDLG), 0,
                                     wait_dlgproc, (LPARAM)prettyprint_configdir() );
-    ShowWindow( hwnd, SW_SHOWNORMAL );
+    WCHAR *hide = _wgetenv( L"WINEHIDEWAIT" );
+    if (hide == NULL) {
+        ShowWindow( hwnd, SW_SHOWNORMAL );
+    }
     return hwnd;
 }
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/2552

[PATCH v6 2/2] Change `WINEHIDEWAIT` to `WINEBOOT_HIDE_DIALOG`

[Isaac Marovitz]

From: Isaac Marovitz <isaacryu(a)icloud.com>

---
 programs/wineboot/wineboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c
index 14fd9f0c5dc..3014cb53211 100644
--- a/programs/wineboot/wineboot.c
+++ b/programs/wineboot/wineboot.c
@@ -1341,7 +1341,7 @@ static HWND show_wait_window(void)
 {
     HWND hwnd = CreateDialogParamW( GetModuleHandleW(0), MAKEINTRESOURCEW(IDD_WAITDLG), 0,
                                     wait_dlgproc, (LPARAM)prettyprint_configdir() );
-    WCHAR *hide = _wgetenv( L"WINEHIDEWAIT" );
+    WCHAR *hide = _wgetenv( L"WINEBOOT_HIDE_DIALOG" );
     if (hide == NULL) {
         ShowWindow( hwnd, SW_SHOWNORMAL );
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2552

[Loïc Rebmeister]

On Sat Apr  1 16:35:42 2023 +0000, Isaac Marovitz wrote:
> `WINEBOOT_HIDE_DIALOG` lgtm
> Well, your PR, your choice.

`WINEHIDEDIALOG` seems fine for me too.

But I feel like the `WAIT` keyword doesn't fit right in for the env name.

Pick whichever you prefer.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2552#note_28591

[Loïc Rebmeister]

On Sat Apr  1 17:15:45 2023 +0000, Loïc Rebmeister wrote:
> Well, your PR, your choice.
> `WINEHIDEDIALOG` seems fine for me too.
> But I feel like the `WAIT` keyword doesn't fit right in for the env name.
> Pick whichever you prefer.
> As I said it's mainly dependent on personal preferences, this is why I asked the [wine-tkg community Discord](https://discord.gg/jRy3Nxk) about it.

You should join it, it's a really cool community.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2552#note_28593