[PATCH 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.

[Yeshun Ye (＠yeyeshun)]

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305

[PATCH 1/1] rpcrt4: Pass the binding handle to server call function.

[YeshunYe]

From: YeshunYe <yeyeshun(a)uniontech.com>

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com>
---
 dlls/rpcrt4/ndr_stubless.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c
index 8fc5fd41ca6..c94a45338cf 100644
--- a/dlls/rpcrt4/ndr_stubless.c
+++ b/dlls/rpcrt4/ndr_stubless.c
@@ -1423,6 +1423,8 @@ LONG WINAPI NdrStubCall2(
      * are calling an object method */
     if (pThis)
         *(void **)args = ((CStdStubBuffer *)pThis)->pvServerObject;
+    else
+        *(void **)args = pRpcMsg->Handle;
 
     if (is_oicf_stubdesc(pStubDesc))
     {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2305

[PATCH 1/1] rpcrt4: Pass the binding handle to server call function.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=130128

Your paranoid android.


=== debian11 (32 bit report) ===

rpcrt4:
Unhandled exception: 0x000003e6 in 32-bit code (0x7b012636).
server.c:1228: unhandled exception 000003e6 in child process 0b0c

=== debian11 (32 bit zh:CN report) ===

rpcrt4:
Unhandled exception: 0x000003e6 in 32-bit code (0x7b012636).
server.c:1228: unhandled exception 000003e6 in child process 01f0

=== debian11b (64 bit WoW report) ===

rpcrt4:
Unhandled exception: 0x000003e6 in 64-bit code (0x0000007b013c5e).
server.c:1228: unhandled exception 000003e6 in child process 01fc

[Yeshun Ye (＠yeyeshun)]

In server call, someone may use the binding handle by I_RpcBindingInqLocalClientPID to get the client process id.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_25844

[Yeshun Ye (＠yeyeshun)]

ok, I will check.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_25846

[Zhiyi Zhang (＠zhiyi)]

Could you add a test for this change?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_25850

[Yeshun Ye (＠yeyeshun)]

On Wed Mar  1 08:43:14 2023 +0000, Zhiyi Zhang wrote:
> Could you add a test for this change?
> not now. I will check the test error first.    
> I cannot pass the test even I revert my patch, can you tell me how to run the test correctly?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_25860

[Zhiyi Zhang (＠zhiyi)]

On Wed Mar  1 08:43:14 2023 +0000, Yeshun Ye wrote:
> not now. I will check the test error first.    
> I cannot pass the test even I revert my patch, can you tell me how to
> run the test correctly?
> Make sure you pass the tests on the TestBots at https://testbot.winehq.org/Submit.pl first. If you have other tests failing only locally, you can comment them out for the time being.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_25861