Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c:
> {
>      const struct smbios_header *hdr;
> -    const struct smbios_baseboard *baseboard;
>      UINT offset;
>
> -    if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL;
> +    if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL;
>
> -    baseboard = (const struct smbios_baseboard *)hdr;
> -    offset = (const char *)baseboard - buf + baseboard->hdr.length;
> -    return get_smbios_string( id, buf, offset, len );
> +    if (field_offset + sizeof(BYTE) > hdr->length) return NULL;
> +
> +    offset = (const char *)hdr - buf + hdr->length;
> +    return get_smbios_string_internal( ((const BYTE*)hdr)[field_offset], buf, offset, len );
>  }
> Please add a space before the asterisk.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48965