Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c:
> int ret;
>
> -    if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP)
> +    if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP))
>      {
>          BCRYPT_OAEP_PADDING_INFO *pad = params->padding;
>          gnutls_digest_algorithm_t dig;
>          gnutls_datum_t label;
>
> +        /* For OAEP decryption Windows requires a padding info structure with a hash
> +         * algorithm; label may be empty (pbLabel == NULL and cbLabel == 0). */
>          if (!pad || !pad->pszAlgId)
>          {
>              WARN( "padding info not found\n" );
>              return STATUS_INVALID_PARAMETER;
>          }

The comment is not very useful as it only states what the code does. Please remove it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130897