Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.

[Daniel Lehman (＠dlehman25)]

> Wait, what's partial about it?

i don't handle the 2nd argument, but it doesn't seem to be used for what i need, though.  i can implement the higher level kernel32 call without it

what about something like this, copied from NtUnlockFile:
`
    TRACE( "(%p %p %p)\n", handle, io, io_status );
    if (io) FIXME("Unimplemented yet parameter\n");
`

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3914

[PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.

[Zebediah Figura]

On 7/11/22 21:50, Daniel Lehman (@dlehman25) wrote:
> > Wait, what's partial about it?
>
> i don't handle the 2nd argument, but it doesn't seem to be used for what i need, though.  i can implement the higher level kernel32 call without it
>
> what about something like this, copied from NtUnlockFile:
> `
>      TRACE( "(%p %p %p)\n", handle, io, io_status );
>      if (io) FIXME("Unimplemented yet parameter\n");
> `

That sounds to me like the ideal thing to do.