Re: [PATCH v2 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
10 Oct
2022
10 Oct
'22
10:11 p.m.
On Mon Oct 10 21:33:57 2022 +0000, Huw Davies wrote:
This looks correct to me, however afaict, Windows also sets `stubMessage.pRpcChannelBuffer` to `NULL` when it releases it, so it would be good to have a test for that, as well as it added to the implementation. It would be clearer to split this into two commits: the first commit would contain just the tests with appropriate `todo_wine`s. A second commit would then add the implementation changes and remove the `todo_wine`s. That way it's clear what the new changes are fixing. Ok, easy to do
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/957#note_10232
1162
Age (days ago)
1162
Last active (days ago)
0 comments
1 participants
participants (1)
-
Kevin Puetz (@puetzk)