[PATCH 0/1] MR3838: kernel32/tests: Allow a 0 removed entry count in the completion test.

[Francois Gouget (＠fgouget)]

This matches the ntdll:file fix.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54554

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

[PATCH 1/1] kernel32/tests: Allow a 0 removed entry count in the completion test.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

This matches the ntdll:file fix.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54554
---
 dlls/kernel32/tests/file.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c
index 65164d7f2a4..7044a992bb6 100644
--- a/dlls/kernel32/tests/file.c
+++ b/dlls/kernel32/tests/file.c
@@ -5559,7 +5559,7 @@ static void test_post_completion(void)
     ret = pGetQueuedCompletionStatusEx( port, entries, 2, &count, 0, FALSE );
     ok(!ret, "GetQueuedCompletionStatusEx succeeded\n");
     ok(GetLastError() == WAIT_TIMEOUT, "wrong error %lu\n", GetLastError());
-    ok(count == 1, "wrong count %lu\n", count);
+    ok(count <= 1, "wrong count %lu\n", count);
 
     ret = PostQueuedCompletionStatus( port, 123, 456, &ovl );
     ok(ret, "PostQueuedCompletionStatus failed: %lu\n", GetLastError());
@@ -5600,14 +5600,14 @@ static void test_post_completion(void)
     ret = pGetQueuedCompletionStatusEx( port, entries, 2, &count, 0, FALSE );
     ok(!ret, "GetQueuedCompletionStatusEx succeeded\n");
     ok(GetLastError() == WAIT_TIMEOUT, "wrong error %lu\n", GetLastError());
-    ok(count == 1, "wrong count %lu\n", count);
+    ok(count <= 1, "wrong count %lu\n", count);
     ok(!user_apc_ran, "user APC should not have run\n");
 
     ret = pGetQueuedCompletionStatusEx( port, entries, 2, &count, 0, TRUE );
     ok(!ret || broken(ret) /* Vista */, "GetQueuedCompletionStatusEx succeeded\n");
     if (!ret)
         ok(GetLastError() == WAIT_IO_COMPLETION, "wrong error %lu\n", GetLastError());
-    ok(count == 1, "wrong count %lu\n", count);
+    ok(count <= 1, "wrong count %lu\n", count);
     ok(user_apc_ran, "user APC should have run\n");
 
     user_apc_ran = FALSE;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

[PATCH 1/1] kernel32/tests: Allow a 0 removed entry count in the completion test.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

2 TestBot errors prevented a full analysis of your patch.
If the test caused the operating system (e.g. Windows) to crash or
reboot you will probably have to modify it to avoid that.
Other issues should be reported to the TestBot administrators.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=151954

Your paranoid android.


=== build (build log) ===

WineRunBuild.pl:error: Could not copy the patch to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunBuild.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

=== debian11 (build log) ===

error: patch failed: dlls/kernel32/tests/file.c:5559
Task: Patch failed to apply

=== debian11b (build log) ===

WineRunWineTest.pl:error: Could not send 'patch.diff' to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunWineTest.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)
WineRunWineTest.pl:error: Giving up after 3 run(s)